pgsql: Remove useless code

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove useless code
Date: 2024-07-01 06:55:04
Message-ID: E1sOAwJ-003lBR-G8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove useless code

BuildDescForRelation() goes out of its way to fill in
->constr->has_not_null, but that value is not used for anything later,
so this code can all be removed. Note that BuildDescForRelation()
doesn't make any effort to fill in the rest of ->constr, so there is
no claim that that structure is completely filled in.

Reviewed-by: Tomasz Rybak <tomasz(dot)rybak(at)post(dot)pl>
Discussion: https://www.postgresql.org/message-id/flat/a368248e-69e4-40be-9c07-6c3b5880b0a6(at)eisentraut(dot)org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e26d313bad92e71e2b59cc2e81870bf6d750de1f

Modified Files
--------------
src/backend/commands/tablecmds.c | 25 +++----------------------
1 file changed, 3 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-07-01 09:19:18 pgsql: Add context type field to pg_backend_memory_contexts
Previous Message Peter Eisentraut 2024-07-01 06:44:22 pgsql: doc: Clarify that pg_attrdef also stores generation expressions