| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Make pg_createsubscriber more wary about quoting connection para |
| Date: | 2024-06-30 17:45:31 |
| Message-ID: | E1sNycE-003gh4-EE@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Make pg_createsubscriber more wary about quoting connection parameters.
The original coding here could fail with database names, user names,
etc that contain spaces or other special characters.
As partial test coverage, extend the 040_pg_createsubscriber.pl
test script so that it uses a generated database name containing
funny characters.
Hayato Kuroda (some mods by me), per complaint from Noah Misch
Discussion: https://postgr.es/m/20240623062157.97.nmisch@google.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/b3f5ccebd79d9c7b73f4e04611cdf31fdf87420b
Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 53 ++++++----
src/bin/pg_basebackup/t/040_pg_createsubscriber.pl | 111 ++++++++++++---------
2 files changed, 96 insertions(+), 68 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-06-30 18:24:23 | pgsql: Make pg_createsubscriber warn if publisher has two-phase commit |
| Previous Message | Noah Misch | 2024-06-28 18:20:08 | pgsql: Fix .gitignore for new injection suite. |