pgsql: SQL/JSON: Correct jsonpath variable name matching

From: Amit Langote <amitlan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: SQL/JSON: Correct jsonpath variable name matching
Date: 2024-06-19 06:48:09
Message-ID: E1sJp72-002765-A3@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

SQL/JSON: Correct jsonpath variable name matching

Previously, GetJsonPathVar() allowed a jsonpath expression to
reference any prefix of a PASSING variable's name. For example, the
following query would incorrectly work:

SELECT JSON_QUERY(context_item, jsonpath '$xy' PASSING val AS xyz);

The fix ensures that the length of the variable name mentioned in a
jsonpath expression matches exactly with the name of the PASSING
variable before comparing the strings using strncmp().

Reported-by: Alvaro Herrera (off-list)
Discussion: https://postgr.es/m/CA+HiwqFGkLWMvELBH6E4SQ45qUHthgcRH6gCJL20OsYDRtFx_w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0f271e8e8d9c8db0ea86c0d12b3221009b81d8bf

Modified Files
--------------
src/backend/executor/execExpr.c | 1 +
src/backend/utils/adt/jsonpath_exec.c | 4 +++-
src/include/utils/jsonpath.h | 1 +
src/test/regress/expected/sqljson_queryfuncs.out | 11 +++++++++++
src/test/regress/sql/sqljson_queryfuncs.sql | 5 +++++
5 files changed, 21 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-06-19 21:13:05 pgsql: Fix comment in pg_upgrade.h.
Previous Message Bruce Momjian 2024-06-19 02:42:12 pgsql: doc PG 17 relnotes: properly wrap SGML text