pgsql: pg_createsubscriber: Remove replication slot check on primary

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_createsubscriber: Remove replication slot check on primary
Date: 2024-06-17 08:55:03
Message-ID: E1sJ88k-001rrw-J9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_createsubscriber: Remove replication slot check on primary

It used to check if the replication slot exists and is active on
primary. This check might fail on slow hosts because the replication
slot might not be active at the time of this check.

The current code obtains the replication slot name from the
primary_slot_name on standby and assumes the replication slot exists
and is active on primary. If it doesn't exist, this tool will log an
error and continue.

Author: Euler Taveira <euler(dot)taveira(at)enterprisedb(dot)com>
Reviewed-by: Hayato Kuroda <kuroda(dot)hayato(at)fujitsu(dot)com>
Discussion: https://www.postgresql.org/message-id/776c5cac-5ef5-4001-b1bc-5b698bc0c62a%40app.fastmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b96391382626306c301b67cbd2d28313d96741f3

Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 48 +----------------------------
1 file changed, 1 insertion(+), 47 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-06-17 10:16:20 pgsql: pg_createsubscriber: Remove failover replication slots on subscr
Previous Message Peter Eisentraut 2024-06-17 07:59:22 pgsql: pg_createsubscriber: Only --recovery-timeout controls the end of