pgsql: Reintroduce dead tuple counter in pg_stat_progress_vacuum.

From: Masahiko Sawada <msawada(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Reintroduce dead tuple counter in pg_stat_progress_vacuum.
Date: 2024-06-14 01:09:34
Message-ID: E1sHvRd-001OyZ-CN@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Reintroduce dead tuple counter in pg_stat_progress_vacuum.

Commit 667e65aac3 changed both num_dead_tuples and max_dead_tuples
columns to dead_tuple_bytes and max_dead_tuple_bytes columns,
respectively. But as per discussion, the number of dead tuples
collected still provides meaningful insights for users.

This commit reintroduces the column for the count of dead tuples,
renamed as num_dead_item_ids. It avoids confusion with the number of
dead tuples removed by VACUUM, which includes dead heap-only tuples
but excludes any pre-existing LP_DEAD items left behind by
opportunistic pruning.

Bump catalog version.

Reviewed-by: Peter Geoghegan, Álvaro Herrera, Andrey Borodin
Discussion: https://postgr.es/m/CAD21AoBL5sJE9TRWPyv%2Bw7k5Ee5QAJqDJEDJBUdAaCzGWAdvZw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f1affb67055c9b3f31a7ee7eb521a9ba64fff488

Modified Files
--------------
doc/src/sgml/monitoring.sgml | 9 +++++++++
src/backend/access/heap/vacuumlazy.c | 12 +++++++++---
src/backend/catalog/system_views.sql | 3 ++-
src/include/catalog/catversion.h | 2 +-
src/include/commands/progress.h | 5 +++--
src/test/regress/expected/rules.out | 5 +++--
6 files changed, 27 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-06-14 19:29:32 pgsql: Fix misc_sanity test to accept SHARED_DEPENDENCY_INITACL entries
Previous Message Tom Lane 2024-06-14 00:35:10 pgsql: Fix parsing of ignored operators in websearch_to_tsquery().