From: | Etsuro Fujita <efujita(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote ser |
Date: | 2024-06-07 08:55:33 |
Message-ID: | E1sFVNk-000Nvd-9T@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
postgres_fdw: Refuse to send FETCH FIRST WITH TIES to remote servers.
Previously, when considering LIMIT pushdown, postgres_fdw failed to
check whether the query has this clause, which led to pushing false
LIMIT clauses, causing incorrect results.
This clause has been supported since v13, so we need to do a
remote-version check before deciding that it will be safe to push such a
clause, but we do not currently have a way to do the check (without
accessing the remote server); disable pushing such a clause for now.
Oversight in commit 357889eb1. Back-patch to v13, where that commit
added the support.
Per bug #18467 from Onder Kalaci.
Patch by Japin Li, per a suggestion from Tom Lane, with some changes to
the comments by me. Review by Onder Kalaci, Alvaro Herrera, and me.
Discussion: https://postgr.es/m/18467-7bb89084ff03a08d%40postgresql.org
Branch
------
REL_14_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/269e2c39162811a170d7e8f87a1a0bde3b9e2fab
Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 21 +++++++++++++++++++++
contrib/postgres_fdw/postgres_fdw.c | 14 ++++++++++++++
contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++++
3 files changed, 40 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-06-07 09:47:07 | pgsql: Add more debugging information when dropping twice pgstats entry |
Previous Message | Peter Eisentraut | 2024-06-07 07:37:00 | pgsql: meson: Restore implicit warning/debug/optimize flags for extensi |