pgsql: Fix query result leak during binary upgrade

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix query result leak during binary upgrade
Date: 2024-05-15 20:52:48
Message-ID: E1s7LcH-000O3B-1S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix query result leak during binary upgrade

9a974cbcba00 moved the query in binary_upgrade_set_pg_class_oids to the
outer level, but left the PQclear and query buffer destruction in the
is_index conditional. 353708e1fb2d fixed the leak of the query buffer
but left the PGresult leak. This moves clearing the result to the outer
level ensuring that it will be called.

Reviewed-by: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Discussion: https://postgr.es/m/374550C1-F4ED-4D9D-9498-0FD029CCF674@yesql.se
Backpatch-through: v15

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a8f87d5d21c2f3ddd644c9cb313ecd43290a446e

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2024-05-15 20:53:57 pgsql: Fix query result leak during binary upgrade
Previous Message Jacob Champion 2024-05-15 18:22:58 Re: pgsql: Fix overread in JSON parsing errors for incomplete byte sequence