pgsql: Remove auth-options support from initdb

From: Daniel Gustafsson <dgustafsson(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove auth-options support from initdb
Date: 2024-05-14 09:11:49
Message-ID: E1s6oCL-0008sH-OQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove auth-options support from initdb

When --auth was added to initdb in commit e7029b212755 it had support
for auth options separated by space from the auth type, like:

--auth pam <servicename>
--auth ident sameuser

Passing an option to the ident auth type was removed in 01c1a12a5bb4
which left the pam auth-options support in place. 8a02339e9ba3 broke
this by inverting a calculation in the strncmp arguments, which went
unnoticed for a long time. The ability to pass options to the auth
type was never documented.

Rather than fixing the support for an undocumented feature which has
been broken for all supported versions, and which only supports one
out of many auth types which can take options, it is removed.

Reported-by: Jingxian Li <aqktjcm(at)qq(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Reviewed-by: Aleksander Alekseev <aleksander(at)timescale(dot)com>
Discussion: https://postgr.es/m/tencent_29731C7C7E6A2F9FB807C3A1DC3D81293C06@qq.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/83ae824c87a59f1183de560b2560641ab804c729

Modified Files
--------------
src/bin/initdb/initdb.c | 8 ++------
1 file changed, 2 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-14 09:37:13 pgsql: Add missing source files to pg_combinebackup/nls.mk
Previous Message Daniel Gustafsson 2024-05-14 08:44:26 pgsql: Fix memory leaks in error reporting with LOG level