pgsql: Skip invalid database pg_upgrade test on obsolete servers

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Skip invalid database pg_upgrade test on obsolete servers
Date: 2024-05-01 09:51:15
Message-ID: E1s26cM-000wvV-LG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Skip invalid database pg_upgrade test on obsolete servers

When testing pg_upgrade against an old server, ignore failures on the
check to upgrade invalid databases. This is necessary because old
servers don't know to raise the appropriate error of the database being
invalid.

This change causes no reduction in coverage, because such old versions
don't know to mark databases invalid when a drop is interrupted; but
testing against such old servers is useful in some circumstances.

Backpatch to 16, where it cherry-picks with minimal conflicts.

On 16, perltidy 20230309 chooses to change an unrelated line. I let it
do that because that's the version we document as preferred for that
branch, even though it would make other changes to many other files in
the tree.

Discussion: https://postgr.es/m/202404181539.lh42llaesnv3@alvherre.pgsql

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5a0ac6855a21917ada42d8bb83d3d5ac4c2eeda8

Modified Files
--------------
src/bin/pg_upgrade/t/002_pg_upgrade.pl | 41 ++++++++++++++++++++++------------
1 file changed, 27 insertions(+), 14 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-05-02 06:17:47 pgsql: doc: Fix description of configure --with-icu option
Previous Message Tatsuo Ishii 2024-05-01 06:29:53 Re: pgsql: Disable run condition optimization for some WindowFuncs