From: | Noah Misch <noah(at)leadboat(dot)com> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Close race condition between datfrozen and relfrozen updates. |
Date: | 2024-04-29 17:30:41 |
Message-ID: | E1s1Upr-000eAQ-W1@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Close race condition between datfrozen and relfrozen updates.
vac_update_datfrozenxid() did multiple loads of relfrozenxid and
relminmxid from buffer memory, and it assumed each would get the same
value. Not so if a concurrent vac_update_relstats() did an inplace
update. Commit 2d2e40e3befd8b9e0d2757554537345b15fa6ea2 fixed the same
kind of bug in vac_truncate_clog(). Today's bug could cause the
rel-level field and XIDs in the rel's rows to precede the db-level
field. A cluster having such values should VACUUM affected tables.
Back-patch to v12 (all supported versions).
Discussion: https://postgr.es/m/20240423003956.e7.nmisch@google.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/f222349c4ec061705e121548d2fe646b4d03ccdf
Modified Files
--------------
src/backend/commands/vacuum.c | 28 ++++++++++++++++------------
1 file changed, 16 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2024-04-29 23:26:24 | pgsql: Fix failure to track role dependencies of pg_init_privs entries. |
Previous Message | Noah Misch | 2024-04-29 17:30:40 | pgsql: Avoid repeating loads of frozen ID values. |