pgsql: Improve comment of DeallocateStmt->isall

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve comment of DeallocateStmt->isall
Date: 2024-04-25 01:22:43
Message-ID: E1rznow-003kZQ-V2@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve comment of DeallocateStmt->isall

This field is not used directly in the code, but it is important for
query jumbling to be able to make a difference between a named
DEALLOCATE and DEALLOCATE ALL (see bb45156f342c). This behavior is
tracked in the regression tests of pg_stat_statements, but the reason
why this field is important can be easily missed, as a recent discussion
has proved, so let's improve its comment to document the reason why it
needs to be around.

Wording has been suggested by Tom Lane

Discussion: https://postgr.es/m/Zih1ATt37YFda8_p@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ee3ef4af19d8ba140a8b33c6598d470d36eec10c

Modified Files
--------------
src/include/nodes/parsenodes.h | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Amit Kapila 2024-04-25 05:33:58 pgsql: Fix the missing table sync due to improper invalidation handling
Previous Message Tom Lane 2024-04-24 14:19:13 pgsql: Doc: fix minor oversight in ALTER DEFAULT PRIVILEGES ref page.