pgsql: Remove some unnecessary fields from executor nodes.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove some unnecessary fields from executor nodes.
Date: 2024-04-23 16:55:33
Message-ID: E1rzJQb-003Wvc-Cu@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove some unnecessary fields from executor nodes.

JsonExprState.input_finfo is only assigned to, never read, and
it's really fairly useless since the value can be gotten out of
the adjacent input_fcinfo field. Let's remove it before someone
starts to depend on it.

While here, also remove TidScanState.tss_htup and AggState.combinedproj,
which are referenced nowhere. Those should have been removed by the
commits that caused them to become disused, but were not.

I don't think a catversion bump is necessary here, since plan trees
are never stored on disk.

Matthias van de Meent

Discussion: https://postgr.es/m/CAEze2WjsY4d0TBymLNGK4zpttUcg_YZaTjyWz2VfDUV6YH8wXQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b7d35d393edbe2d4333dde81496e8a362abc85bd

Modified Files
--------------
src/backend/executor/execExpr.c | 1 -
src/include/nodes/execnodes.h | 4 ----
2 files changed, 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2024-04-23 19:33:34 pgsql: Post review fixes for test_json_parser test module
Previous Message Nathan Bossart 2024-04-23 15:55:02 pgsql: Fix code for probing availability of AVX-512.