From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: createdb: compare strategy case-insensitive |
Date: | 2024-04-21 19:31:24 |
Message-ID: | E1rycuJ-003DFM-Ly@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
createdb: compare strategy case-insensitive
When specifying the createdb strategy, the documentation suggests valid
options are FILE_COPY and WAL_LOG, but the code does case-sensitive
comparison and accepts only "file_copy" and "wal_log" as valid.
Fixed by doing a case-insensitive comparison using pg_strcasecmp(), same
as for other string parameters nearby.
While at it, apply fmtId() to a nearby "locale_provider". This already
did the comparison in case-insensitive way, but the value would not be
double-quoted, confusing the parser and the error message.
Backpatch to 15, where the strategy was introduced.
Backpatch-through: 15
Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/90c6913a-1dd2-42b4-8365-ce3b09c39b17@enterprisedb.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8c239ee15a4b093523ebe30bdc9af186aaccebfd
Modified Files
--------------
src/backend/commands/dbcommands.c | 6 +++---
src/bin/scripts/createdb.c | 2 +-
src/bin/scripts/t/020_createdb.pl | 10 ++++++++++
3 files changed, 14 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tomas Vondra | 2024-04-21 19:31:41 | pgsql: createdb: compare strategy case-insensitive |
Previous Message | Tom Lane | 2024-04-21 17:46:36 | pgsql: Make postgres_fdw request remote time zone 'GMT' not 'UTC'. |