From: | David Rowley <drowley(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Push dedicated BumpBlocks to the tail of the blocks list |
Date: | 2024-04-16 22:40:52 |
Message-ID: | E1rwrTv-002Pn2-LN@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Push dedicated BumpBlocks to the tail of the blocks list
BumpContext relies on using the head block from its 'blocks' field to
use as the current block to allocate new chunks to. When we receive an
allocation request larger than allocChunkLimit, we place these chunks on
a new dedicated block and, until now, we pushed the block onto the
*head* of the 'blocks' list.
This behavior caused the previous bump block to no longer be available
for new normal-sized (non-large) allocations and would result in blocks
only being partially filled if a large allocation request arrived before
the block became full.
Here adjust the code to push these dedicated blocks onto the *tail* of
the blocks list so that the head block remains intact and available to
be used by normal allocation request sizes until it becomes full.
In passing, make the elog(ERROR) calls for the unsupported callbacks
consistent. Likewise for the header comments for those functions.
Discussion: https://postgr.es/m/CAApHDvp9___r-ayJj0nZ6GD3MeCGwGZ0_6ZptWpwj+zqHtmwCw@mail.gmail.com
Discussion: https://postgr.es/m/CAApHDvqerXpzUnuDQfUEi3DZA+9=Ud9WSt3ruxN5b6PcOosx2g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/6d2fd66b9908d1557d7e49b1bdb4c597192f3729
Modified Files
--------------
src/backend/utils/mmgr/bump.c | 17 ++++++++++-------
src/test/regress/expected/sysviews.out | 2 +-
2 files changed, 11 insertions(+), 8 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | David Rowley | 2024-04-16 22:49:44 | pgsql: Update mmgr's README to mention BumpContext |
Previous Message | Peter Eisentraut | 2024-04-16 18:30:06 | pgsql: Mark some new location fields as ParseLoc |