pgsql: Fix a test in failover slots regression test.

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix a test in failover slots regression test.
Date: 2024-04-10 03:23:51
Message-ID: E1ruOYx-001Nf4-Cr@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix a test in failover slots regression test.

Wait for the standby to catch up before syncing the slots with
pg_sync_replication_slots(), otherwise, the logical slot could be ahead
and the sync would fail.

The other way to fix the test is to change it to use slotsync worker and
poll for the sync to get finished but the current approach is better as
this is a predictable way to write the test.

Per buildfarm

Author: Hou Zhijie
Reviewed-by: Amit Kapila
Discussion: https://postgr.es/m/OS0PR01MB571665359F2F5DCD3ADABC9F94002@OS0PR01MB5716.jpnprd01.prod.outlook.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7e85d1c75f299b0772fbeb145706e019629530bd

Modified Files
--------------
src/test/recovery/t/040_standby_failover_slots_sync.pl | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-04-10 04:48:35 pgsql: Make GIN tests using injection points concurrent-safe
Previous Message Thomas Munro 2024-04-10 00:27:35 pgsql: Fix illegal attribute propagation in LLVM JIT.