pgsql: Further review for re-implementation of psql's FETCH_COUNT featu

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Further review for re-implementation of psql's FETCH_COUNT featu
Date: 2024-04-08 19:49:17
Message-ID: E1rtuzU-001B8P-OK@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Further review for re-implementation of psql's FETCH_COUNT feature.

Alexander Lakhin noted an obsolete comment, which led me to revisit
some other important comments in the patch, and that study turned up a
couple of unintended ways in which the chunked-fetch code path didn't
match the normal code path in ExecQueryAndProcessResults. The only
nontrivial problem is that it didn't call PrintQueryStatus, so that
we'd not print the final status result from DML ... RETURNING
commands. To avoid code duplication, move the filter for whether a
result is from RETURNING from PrintQueryResult to PrintQueryStatus.

Discussion: https://postgr.es/m/0023bea5-79c0-476e-96c8-dad599cc3ad8@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/c21d4c416ad61b78cf450f11861bbafbdfb7eebc

Modified Files
--------------
src/bin/psql/common.c | 78 ++++++++++++++++++++++++++++++++-------------------
1 file changed, 49 insertions(+), 29 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-04-08 21:00:16 pgsql: In psql, avoid leaking a PGresult after a query is cancelled.
Previous Message Andres Freund 2024-04-08 17:27:42 Re: pgsql: Teach radix tree to embed values at runtime