pgsql: Fix bogus coding in ExecAppendAsyncEventWait().

From: Etsuro Fujita <efujita(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bogus coding in ExecAppendAsyncEventWait().
Date: 2024-04-04 08:37:31
Message-ID: E1rsIbD-000Q7g-Ea@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bogus coding in ExecAppendAsyncEventWait().

No configured-by-FDW events would result in "return" directly out of a
PG_TRY block, making the exception stack dangling. Repair.

Oversight in commit 501cfd07d; back-patch to v14, like that commit, but
as we do not have this issue in HEAD (cf. commit 50c67c201), no need to
apply this patch to it.

In passing, improve a comment about the handling of in-process requests
in a postgres_fdw.c function called from this function.

Alexander Pyhalov, with comment adjustment/improvement by me.

Discussion: https://postgr.es/m/425fa29a429b21b0332737c42a4fdc70%40postgrespro.ru

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f6f61a4bd9cc8d771c3b33feeee5cfc039c5e05d

Modified Files
--------------
contrib/postgres_fdw/postgres_fdw.c | 18 ++++++++++--------
src/backend/executor/nodeAppend.c | 31 +++++++++++++++----------------
2 files changed, 25 insertions(+), 24 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Etsuro Fujita 2024-04-04 08:37:32 pgsql: Fix bogus coding in ExecAppendAsyncEventWait().
Previous Message David Rowley 2024-04-04 06:23:41 pgsql: Secondary refactor of heap scanning functions