| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Fix assorted resource leaks in new pg_createsubscriber code. |
| Date: | 2024-04-01 17:48:02 |
| Message-ID: | E1rrLlJ-0000m1-TW@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Fix assorted resource leaks in new pg_createsubscriber code.
Various error paths did not release resources before returning.
While it's likely that the program would just exit shortly later,
none of the functions in question have summary exit(1) calls,
so they should not be assuming that.
Ranier Vilela and Tom Lane, per reports from Coverity
Discussion: https://postgr.es/m/CAEudQAr2_SZFxB4kXJiL4+2UaNZxUk5UBJtj0oXyJYMGZu-03g@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/91cbb4b492cbea889e8392a85e246c1778ca2a45
Modified Files
--------------
src/bin/pg_basebackup/pg_createsubscriber.c | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2024-04-01 19:15:21 | pgsql: Avoid possible longjmp-induced logic error in PLy_trigger_build_ |
| Previous Message | Heikki Linnakangas | 2024-04-01 17:35:14 | pgsql: Handle non-chain tuples outside of heap_prune_chain() |