pgsql: Stabilize postgres_fdw test

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Stabilize postgres_fdw test
Date: 2024-03-30 13:20:06
Message-ID: E1rqYcw-006UYO-0z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Stabilize postgres_fdw test

The test fails when RESET statement_timeout takes longer than 10ms.
Avoid the problem by using SET LOCAL instead.

Overall, this test is not ideal: 10ms could be shorter than the time to
have sent the query to the "remote" server, so it's possible that on
some machines this test doesn't actually witness a remote query being
cancelled. We may want to improve on this someday by using some other
testing technique, but for now it's better than nothing. I verified
manually that one round of remote cancellation occurs when this runs on
my machine.

Discussion: https://postgr.es/m/CAGECzQRsdWnj=YaaPCnA8d7E1AdbxRPBYmyBQRMPUijR2MpM_w@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ecf741cfae0603d1df269d8b799455bbcaef86e7

Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 5 +++--
contrib/postgres_fdw/sql/postgres_fdw.sql | 5 +++--
2 files changed, 6 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2024-03-30 17:57:24 pgsql: Add pg_basetype() function to extract a domain's base type.
Previous Message Alvaro Herrera 2024-03-30 13:09:58 pgsql: doc: Improve "Partition Maintenance" section