pgsql: Do not translate dummy SpecialJoinInfos for child joins

From: Amit Langote <amitlan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Do not translate dummy SpecialJoinInfos for child joins
Date: 2024-03-25 09:07:57
Message-ID: E1rogJA-005XlT-MQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Do not translate dummy SpecialJoinInfos for child joins

This teaches build_child_join_sjinfo() to create the dummy
SpecialJoinInfos (those created for inner joins) directly for a given
child join, skipping the unnecessary overhead of translating the
parent joinrel's SpecialJoinInfo.

To that end, this commit moves the code to initialize the dummy
SpecialJoinInfos to a new function named init_dummy_sjinfo() and
changes the few existing sites that have this code and
build_child_join_sjinfo() to call this new function.

Author: Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>
Reviewed-by: Richard Guo <guofenglinux(at)gmail(dot)com>
Reviewed-by: Amit Langote <amitlangote09(at)gmail(dot)com>
Reviewed-by: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
Reviewed-by: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
Discussion: https://postgr.es/m/CAExHW5tHqEf3ASVqvFFcghYGPfpy7o3xnvhHwBGbJFMRH8KjNw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6190d828cd25ae20c0a8548765a0e1b880f1f66d

Modified Files
--------------
src/backend/optimizer/path/costsize.c | 37 ++--------------------
src/backend/optimizer/path/joinrels.c | 58 +++++++++++++++++++++++++----------
src/include/optimizer/paths.h | 2 ++
3 files changed, 46 insertions(+), 51 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2024-03-25 09:40:32 pgsql: reindexdb: Fix warning about uninitialized indices_tables_cell
Previous Message Magnus Hagander 2024-03-25 09:04:27 Re: pgsql: make dist uses git archive