pgsql: Remove custom _jumbleRangeTblEntry()

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Remove custom _jumbleRangeTblEntry()
Date: 2024-03-22 06:27:56
Message-ID: E1rnYNg-0053Ow-7H@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Remove custom _jumbleRangeTblEntry()

This is part of an effort to reduce the number of special cases in the
automatically generated node support functions.

This patch removes _jumbleRangeTblEntry() and instead adds per-field
query_jumble_ignore annotations to match the behavior of the previous
custom code. The pg_stat_statements test suite has some coverage of
this. It gets rid of the switch on rtekind; this should be
technically correct, since we do the equal and copy functions like
this also.

The list of fields to jumble has been checked and is considered
correct as of 8b29a119fd.

Reviewed-by: Andrew Dunstan <andrew(at)dunslane(dot)net>
Discussion: https://www.postgresql.org/message-id/flat/4b27fc50-8cd6-46f5-ab20-88dbaadca645(at)eisentraut(dot)org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/367c989cd8405663bb9a35ec1aa4f79b673a55ff

Modified Files
--------------
src/backend/nodes/queryjumblefuncs.c | 49 ------------------------------------
src/include/nodes/parsenodes.h | 40 ++++++++++++++---------------
2 files changed, 20 insertions(+), 69 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-03-22 06:41:34 pgsql: Make RangeTblEntry dump order consistent
Previous Message Peter Eisentraut 2024-03-22 06:23:26 pgsql: Reformat some node comments