From: | Daniel Gustafsson <dgustafsson(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: pg_upgrade: run all data type checks per connection |
Date: | 2024-03-19 12:38:56 |
Message-ID: | E1rmYk4-004axM-1q@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
pg_upgrade: run all data type checks per connection
The checks for data type usage were each connecting to all databases
in the cluster and running their query. On clusters which have a lot
of databases this can become unnecessarily expensive. This moves the
checks to run in a single connection instead to minimize setup and
teardown overhead.
Reviewed-by: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Reviewed-by: Justin Pryzby <pryzby(at)telsasoft(dot)com>
Reviewed-by: Peter Eisentraut <peter(at)eisentraut(dot)org>
Discussion: https://postgr.es/m/BB4C76F-D416-4F9F-949E-DBE950D37787@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/347758b1206364e3bec5ad6cd649b4ba9fe1be7b
Modified Files
--------------
src/bin/pg_upgrade/check.c | 749 ++++++++++++++++++++++++++--------------
src/bin/pg_upgrade/pg_upgrade.h | 13 +-
src/bin/pg_upgrade/version.c | 265 +-------------
3 files changed, 506 insertions(+), 521 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-03-19 16:08:19 | pgsql: gen_node_support.pl: Mark location fields as type alias ParseLoc |
Previous Message | Peter Eisentraut | 2024-03-19 10:50:36 | pgsql: Use half-open interval notation in without_overlaps tests |