| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Address more review comments on commit 2d819a08a1. |
| Date: | 2024-03-18 18:58:38 |
| Message-ID: | E1rmIBy-004UCS-1V@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Address more review comments on commit 2d819a08a1.
Based on comments from Peter Eisentraut.
* Document CREATE DATABASE ... BUILTIN_LOCALE.
* Determine required encoding based on locale name for CREATE
COLLATION. Use -1 for "C" (requires catversion bump).
* initdb output fixups.
* Make ctype_is_c a constant true for now.
* Fixups to ICU 010_create_database.pl test.
Discussion: https://postgr.es/m/4135cf11-206d-40ed-96c0-9363c1232379@eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/846311051e8fdca4c9db83b2b09425759a8b102d
Modified Files
--------------
doc/src/sgml/ref/create_database.sgml | 18 ++++++++++++++++++
src/backend/commands/collationcmds.c | 2 +-
src/backend/utils/adt/pg_locale.c | 28 +++++++++++++++++++++-------
src/bin/initdb/initdb.c | 7 ++++---
src/bin/initdb/t/001_initdb.pl | 2 +-
src/include/catalog/catversion.h | 2 +-
src/include/utils/pg_locale.h | 1 +
src/test/icu/t/010_database.pl | 12 +++++++++++-
8 files changed, 58 insertions(+), 14 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2024-03-18 22:36:02 | pgsql: Fix another warning, introduced by 846311051e. |
| Previous Message | Alvaro Herrera | 2024-03-18 18:29:21 | pgsql: dblink/isolationtester/fe_utils: Use new cancel API |