pgsql: Refactor initial hash lookup in dynahash.c

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Refactor initial hash lookup in dynahash.c
Date: 2024-03-14 22:57:32
Message-ID: E1rku0y-003p5Q-GF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Refactor initial hash lookup in dynahash.c

The same pattern is used three times in dynahash.c to retrieve a bucket
number and a hash bucket from a hash value. This has popped up while
discussing improvements for the type cache, where this piece of
refactoring would become useful.

Note that hash_search_with_hash_value() does not need the bucket number,
just the hash bucket.

Author: Teodor Sigaev
Reviewed-by: Aleksander Alekseev, Michael Paquier
Discussion: https://postgr.es/m/5812a6e5-68ae-4d84-9d85-b443176966a1@sigaev.ru

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/cc5ef90edd809eaf85e11a0ee251229bbf7ce798

Modified Files
--------------
src/backend/utils/hash/dynahash.c | 75 +++++++++++++++++----------------------
1 file changed, 33 insertions(+), 42 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2024-03-14 23:33:23 pgsql: Add basic TAP tests for the low-level backup method, take two
Previous Message David Rowley 2024-03-14 22:56:08 pgsql: Trim ORDER BY/DISTINCT aggregate pathkeys in gather_grouping_pat