pgsql: Fix the intermittent buildfarm failures in 031_column_list.

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix the intermittent buildfarm failures in 031_column_list.
Date: 2024-02-22 06:48:18
Message-ID: E1rd2sU-0006BD-A8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix the intermittent buildfarm failures in 031_column_list.

The reason was that the ALTER SUBSCRIPTION .. SET PUBLICATION will lead to
the restarting of apply worker and after the restart, the apply worker
will use the existing slot and replication origin corresponding to the
subscription. Now, it is possible that before restart the origin has not
been updated and the WAL start location points to a location before where
PUBLICATION exists which can lead to the error "publication ... does not
exist".

Fix it by recreating the subscription as a newly created subscription will
start processing WAL from the recent WAL location and will see the
required publication.

This behavior has existed from the time logical replication was introduced
but is exposed by this test and we have started a discussion for a better
fix for this problem.

As per Buildfarm

Diagnosed-by: Amit Kapila
Author: Vignesh C
Discussion: https://postgr.es/m/3307255.1706911634@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b6df0798a5e2480d28cceee7df3f58650cf6fa7a

Modified Files
--------------
src/test/subscription/t/031_column_list.pl | 43 +++++++++++++++++++-----------
1 file changed, 28 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-02-22 07:01:11 pgsql: pgindent fix
Previous Message Peter Eisentraut 2024-02-22 06:11:47 pgsql: Remove custom Constraint node read/write implementations