From: | Amit Kapila <akapila(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve ERROR/LOG messages added by commits ddd5f4f54a and 7a424 |
Date: | 2024-02-22 06:01:27 |
Message-ID: | E1rd298-0005ik-R4@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve ERROR/LOG messages added by commits ddd5f4f54a and 7a424ece48.
Additionally, in slotsync.c, replace one StringInfoData variable usage
with a constant string to avoid palloc/pfree. Also, replace the inclusion
of "logical.h" with "slot.h" to prevent the exposure of unnecessary
implementation details.
Reported-by: Kyotaro Horiguchi, Masahiko Sawada
Author: Shveta Malik based on suggestions by Robert Haas and Amit Kapila
Reviewed-by: Kyotaro Horiguchi, Amit Kapila
Discussion: https://postgr.es/m/20240214.162652.773291409747353211.horikyota.ntt@gmail.com
Discussion: https://postgr.es/m/20240219.134015.1888940527023074780.horikyota.ntt@gmail.com
Discussion: https://postgr.es/m/CAD21AoCYXhDYOQDAS-rhGasC2T+tYbV=8Y18o94sB=5AxcW+yA@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/801792e528d6cb5eeb3a70f5ceb10b15bf92f0c7
Modified Files
--------------
src/backend/replication/logical/slotsync.c | 65 +++++++++-------------
.../recovery/t/040_standby_failover_slots_sync.pl | 2 +-
2 files changed, 28 insertions(+), 39 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-02-22 06:11:47 | pgsql: Remove custom Constraint node read/write implementations |
Previous Message | Michael Paquier | 2024-02-22 01:03:56 | pgsql: Speed up uuid_out() by not relying on a StringInfo |