From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Add lookup table for replication slot conflict reasons |
Date: | 2024-02-21 23:41:56 |
Message-ID: | E1rcwDs-0002lR-Be@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Add lookup table for replication slot conflict reasons
This commit switches the handling of the conflict cause strings for
replication slots to use a table rather than being explicitly listed,
using a C99-designated initializer syntax for the array elements. This
makes the whole more readable while easing future maintenance with less
areas to update when adding a new conflict reason.
This is similar to 74a730631065, but the scale of the change is smaller
as there are less conflict causes than LWLock builtin tranche names.
Author: Bharath Rupireddy
Reviewed-by: Jelte Fennema-Nio
Discussion: https://postgr.es/m/CALj2ACUxSLA91QGFrJsWNKs58KXb1C03mbuwKmzqqmoAKLwJaw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/943f7ae1c8693cf3ea59d103aaf9590ea062fb9c
Modified Files
--------------
src/backend/replication/slot.c | 45 ++++++++++++++++++++++++++-----------
src/backend/replication/slotfuncs.c | 24 +++++---------------
src/include/replication/slot.h | 13 +++++------
3 files changed, 43 insertions(+), 39 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2024-02-22 01:03:56 | pgsql: Speed up uuid_out() by not relying on a StringInfo |
Previous Message | Heikki Linnakangas | 2024-02-21 23:23:30 | pgsql: Remove superfluous 'pgprocno' field from PGPROC |