pgsql: Introduce overflow-safe integer comparison functions.

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Introduce overflow-safe integer comparison functions.
Date: 2024-02-16 19:38:40
Message-ID: E1rb42i-006aEE-4M@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Introduce overflow-safe integer comparison functions.

This commit adds integer comparison functions that are designed to
be as efficient as possible while avoiding overflow. A follow-up
commit will make use of these functions in many of the in-tree
qsort() comparators. The new functions are not better in all cases
(e.g., when the comparator function is inlined), so it is important
to consider the context before using them.

Author: Mats Kindahl
Reviewed-by: Tom Lane, Heikki Linnakangas, Andres Freund, Thomas Munro, Andrey Borodin, Fabrízio de Royes Mello
Discussion: https://postgr.es/m/CA%2B14426g2Wa9QuUpmakwPxXFWG_1FaY0AsApkvcTBy-YfS6uaw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6b80394781c8de17fe7cae6996476088af3c319f

Modified Files
--------------
src/include/common/int.h | 75 +++++++++++++++++++++++++++++++++++++++--
src/include/lib/sort_template.h | 13 +++++++
2 files changed, 86 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-02-16 20:06:31 pgsql: Use new overflow-safe integer comparison functions.
Previous Message Jeff Davis 2024-02-16 19:20:47 pgsql: Pass correct count to WALRead().