pgsql: Check that MyProcPid == getpid() in backend signal handlers.

From: Nathan Bossart <nathan(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Check that MyProcPid == getpid() in backend signal handlers.
Date: 2024-02-14 20:53:17
Message-ID: E1raMFp-006FQM-5z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Check that MyProcPid == getpid() in backend signal handlers.

In commit 97550c0711, we added a similar check to the SIGTERM
handler for the startup process. This commit adds this check to
backend signal handlers installed with pqsignal(). This is done by
using a wrapper function that performs the check before calling the
actual handler.

The hope is that this will offer more general protection against
child processes of Postgres backends inadvertently modifying shared
memory due to inherited signal handlers. Another potential
follow-up improvement is to use this wrapper handler function to
restore errno instead of relying on each individual handler
function to do so.

This commit makes the changes in commit 97550c0711 obsolete but
leaves reverting it for a follow-up commit.

Reviewed-by: Andres Freund, Noah Misch
Discussion: https://postgr.es/m/20231121212008.GA3742740%40nathanxps13

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3b00fdba9f20b641d5d3c2b781cd435b23540e61

Modified Files
--------------
src/port/pqsignal.c | 86 +++++++++++++++++++++++++++++++++++++++++++++++++++--
1 file changed, 84 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-02-14 22:35:19 pgsql: Centralize logic for restoring errno in signal handlers.
Previous Message Nathan Bossart 2024-02-14 17:49:08 pgsql: Allow pg_monitor to execute pg_current_logfile().