pgsql: Fix multiranges to behave more like dependent types.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix multiranges to behave more like dependent types.
Date: 2024-02-14 16:30:49
Message-ID: E1raI9p-006Dc1-GT@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix multiranges to behave more like dependent types.

For most purposes, multiranges act like dependent objects of the
associated range type: you can't create them separately or drop them
separately. This is like the way that autogenerated array types
behave. However, a couple of points were overlooked: array types
automatically track the ownership of their base type, and array types
do not have their own permissions but use those of the base type,
while multiranges didn't emulate those behaviors. This is fairly
broken, mainly because pg_dump doesn't think it needs to worry about
multiranges as separate objects, and thus it fails to dump/restore
ownership or permissions of multiranges.

There's no apparent value in letting a multirange diverge from
its parent's ownership or permissions, so let's make them act like
arrays in these respects. However, we continue to let multiranges
be renamed or moved to a different schema independently of their
parent, since that doesn't break anything.

Discussion: https://postgr.es/m/1580383.1705343264@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3e8235ba4f9cc3375b061fb5d3f3575434539b5f

Modified Files
--------------
src/backend/catalog/aclchk.c | 35 ++++++++++++++++++++++
src/backend/catalog/pg_type.c | 41 ++++++++++++++++++--------
src/backend/commands/typecmds.c | 42 +++++++++++++++++++++++----
src/bin/pg_dump/pg_dump.c | 8 ++---
src/test/regress/expected/dependency.out | 1 -
src/test/regress/expected/multirangetypes.out | 30 +++++++++++++++++++
src/test/regress/sql/multirangetypes.sql | 21 ++++++++++++++
7 files changed, 155 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Nathan Bossart 2024-02-14 17:49:08 pgsql: Allow pg_monitor to execute pg_current_logfile().
Previous Message Amit Kapila 2024-02-14 11:00:24 pgsql: Fix BF introduced in commit ddd5f4f54a.