pgsql: Simplify partial path generation in GROUP BY/ORDER BY

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Simplify partial path generation in GROUP BY/ORDER BY
Date: 2024-01-30 21:11:48
Message-ID: E1rUvOW-003tm5-TW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Simplify partial path generation in GROUP BY/ORDER BY

Here we consolidate the generation of partial sort and partial incremental
sort paths in a similar way to what was done in 4a29eabd1. Since the cost
penalty for incremental sort was removed by that commit, there's no
point in creating a sort path on the cheapest partial path if an
incremental sort could be done instead.

This has the added benefit of reducing the amount of code required to
build these paths.

Author: Richard Guo
Reviewed-by: Etsuro Fujita, Shubham Khanna, David Rowley
Discussion: https://postgr.es/m/CAMbWs49PaKxBZU9cN7k3DKB7id+YfGfOfS9H_Fo5tkqPMt=fDg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/8ee9c250875157d42f7ed53508e239d23ce514fb

Modified Files
--------------
src/backend/optimizer/plan/planner.c | 201 ++++++++++----------------
src/test/regress/expected/select_parallel.out | 53 +++++++
src/test/regress/sql/select_parallel.sql | 26 ++++
3 files changed, 156 insertions(+), 124 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2024-01-30 22:13:23 pgsql: Fix 003_extrafiles.pl test for the Windows
Previous Message Alvaro Herrera 2024-01-30 17:13:02 pgsql: Split use of SerialSLRULock, creating SerialControlLock