pgsql: Revert "Add support for parsing of large XML data (>= 10MB)"

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "Add support for parsing of large XML data (>= 10MB)"
Date: 2024-01-26 01:23:47
Message-ID: E1rTAwd-0037xa-2s@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "Add support for parsing of large XML data (>= 10MB)"

This reverts commit 2197d06224a1, following a discussion over a Coverity
report where issues like the "Billion laugh attack" could cause the
backend to waste CPU and memory even if a client applied checks on the
size of the data given in input, and libxml2 does not offer guarantees
that input limits are respected under XML_PARSE_HUGE.

Discussion: https://postgr.es/m/ZbHlgrPLtBZyr_QW@paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f2743a7d70e7b2891277632121bb51e739743a47

Modified Files
--------------
contrib/xml2/xpath.c | 4 ++--
contrib/xml2/xslt_proc.c | 4 ++--
src/backend/utils/adt/xml.c | 38 +++++++++-----------------------------
3 files changed, 13 insertions(+), 33 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2024-01-26 03:20:18 pgsql: Improve NestLoopParam generation for lateral subqueries
Previous Message Heikki Linnakangas 2024-01-25 23:06:06 pgsql: Update comment, generation mem contexts have a "keeper" block