pgsql: Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h"

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h"
Date: 2024-01-23 08:56:22
Message-ID: E1rSCZy-002i7k-U9@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h"

This reverts commit 728f86fec65537eade8d9e751961782ddb527934.

The signal handling was a few bricks shy of a load in that commit,
which made the walreceiver non-responsive to SIGTERM while it was
waiting for the connection to be established. That prevented a standby
from being promoted.

Since it was non-essential refactoring, let's revert it to make v16
work the same as earlier releases. I reverted it in 'master' too, to
keep the branches in sync. The refactoring was a good idea as such,
but it needs a bit more work. Once we have developed a complete patch
with this issue fixed, let's re-apply that to 'master'.

Reported-by: Kyotaro Horiguchi
Backpatch-through: 16
Discussion: https://www.postgresql.org/message-id/20231231.200741.1078989336605759878.horikyota.ntt@gmail.com

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c5a6d5337170a133490c91d7f6d27ac25c47480b

Modified Files
--------------
.../libpqwalreceiver/libpqwalreceiver.c | 55 ++++++++++++++++++----
1 file changed, 47 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2024-01-23 11:20:27 pgsql: meson: portname was set too early
Previous Message Peter Eisentraut 2024-01-23 06:46:14 pgsql: Generate syscache info from catalog files