pgsql: psql: Add ignore_slash_options in bind's inactive branch

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: psql: Add ignore_slash_options in bind's inactive branch
Date: 2024-01-19 05:19:32
Message-ID: E1rQhHw-0026Ye-BF@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

psql: Add ignore_slash_options in bind's inactive branch

All commands accepting arguments, handling them with OT_NORMAL, OT_SQLID
or OT_SQLIDHACK, should call ignore_slash_options() in inactive branch
to scan and discard extra arguments. All the backslash commands that
handle arguments do so, except \bind.

This commit adds the missing ignore_slash_options to \bind's inactive
branch. This inconsistency is a logic bug, however the behavior happens
to be unchanged as any extra arguments are discarded later in
HandleSlashCmds(), so no backpatch is done.

While on it, this adds \bind to the list of backslash commands where
inactive \if branches are checked in the tests for psql.

Reported-by: Jelte Fennema-Nio
Author: Anthonin Bonnefoy
Discussion: https://postgr.es/m/CAGECzQR1+udGKz+FbHiCQ7CWDiF1fCGi2xYuvQUODdMAfJbaLA@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/04c0897d3bcafe4ca61967d5ab1b5669f3cbe80b

Modified Files
--------------
src/bin/psql/command.c | 2 ++
src/test/regress/expected/psql.out | 1 +
src/test/regress/sql/psql.sql | 1 +
3 files changed, 4 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message John Naylor 2024-01-19 05:51:34 pgsql: Add inline incremental hash functions for in-memory use
Previous Message Michael Paquier 2024-01-19 04:21:18 pgsql: Fix incorrect placeholder in walreceiver.c