From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix an issue in PostgreSQL::Test::Cluster:psql() |
Date: | 2024-01-18 07:51:55 |
Message-ID: | E1rQNBr-001yMB-TB@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix an issue in PostgreSQL::Test::Cluster:psql()
Due to the commit c5385929 which made all Perl warnings to fatal, use
of PostgreSQL::Test::Cluster:psql() and safe_psql() with timeout
started to fail with the following error:
Use of uninitialized value $ret in bitwise and (&) at
..src/test/perl/PostgreSQL/Test/Cluster.pm line 2015.
Fix that by placing $ret conversion code in psql() in an if (defined
$ret) block.
With this change, the behavior of psql() becomes same as before, that
is, the whole function returns undef on timeout, which is usefully
different from returning 0.
Author: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/flat/06f899fd-1826-05ab-42d6-adeb1fd5e200%40eisentraut.org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/686db12de3a01222de6bce56f40f4fb9259f7b37
Modified Files
--------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 15 +++++++++------
1 file changed, 9 insertions(+), 6 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2024-01-18 08:38:40 | pgsql: Error message capitalisation |
Previous Message | Michael Paquier | 2024-01-18 07:32:21 | pgsql: Improve handling of dropped partitioned indexes for REINDEX INDE |