From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor ATExecAddColumn() to use BuildDescForRelation() |
Date: | 2024-01-12 15:18:22 |
Message-ID: | E1rOJIc-0015ow-Cq@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor ATExecAddColumn() to use BuildDescForRelation()
BuildDescForRelation() has all the knowledge for converting a
ColumnDef into pg_attribute/tuple descriptor. ATExecAddColumn() can
make use of that, instead of duplicating all that logic. We just pass
a one-element list of ColumnDef and we get back exactly the data
structure we need. Note that we don't even need to touch
BuildDescForRelation() to make this work.
Reviewed-by: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da(at)eisentraut(dot)org
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a1604237a6ffee70b171bacd5f36b0e380afd33a
Modified Files
--------------
src/backend/commands/tablecmds.c | 89 ++++++++++------------------------------
1 file changed, 22 insertions(+), 67 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2024-01-12 21:43:00 | pgsql: Re-validate connection string in libpqrcv_connect(). |
Previous Message | Robert Haas | 2024-01-12 14:50:36 | pgsql: Fix typo. |