pgsql: Teach estimate_array_length() to use statistics where available.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Teach estimate_array_length() to use statistics where available.
Date: 2024-01-04 23:36:29
Message-ID: E1rLXGG-00DXPw-Sb@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Teach estimate_array_length() to use statistics where available.

If we have DECHIST statistics about the argument expression, use
the average number of distinct elements as the array length estimate.
(It'd be better to use the average total number of elements, but
that is not currently calculated by compute_array_stats(), and
it's unclear that it'd be worth extra effort to get.)

To do this, we have to change the signature of estimate_array_length
to pass the "root" pointer. While at it, also change its result
type to "double". That's probably not really necessary, but it
avoids any risk of overflow of the value extracted from DECHIST.
All existing callers are going to use the result in a "double"
calculation anyway.

Paul Jungwirth, reviewed by Jian He and myself

Discussion: https://postgr.es/m/CA+renyUnM2d+SmrxKpDuAdpiq6FOM=FByvi6aS6yi__qyf6j9A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/9391f71523b6e57f1194d9f6543bc7948c16411b

Modified Files
--------------
src/backend/optimizer/path/costsize.c | 10 ++++----
src/backend/utils/adt/arrayfuncs.c | 2 +-
src/backend/utils/adt/selfuncs.c | 47 ++++++++++++++++++++++++++++-------
src/include/utils/selfuncs.h | 2 +-
4 files changed, 45 insertions(+), 16 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message vignesh C 2024-01-05 04:49:48 Re: pg_upgrade test failure
Previous Message Nathan Bossart 2024-01-04 22:11:29 pgsql: Add macros for looping through a List without a ListCell.