pgsql: Set readline-relevant ENV vars in interactive_psql(), not caller

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Set readline-relevant ENV vars in interactive_psql(), not caller
Date: 2023-12-23 16:50:47
Message-ID: E1rH5D4-00BZUC-M4@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Set readline-relevant ENV vars in interactive_psql(), not caller.

Commit 664d75753 pulled 010_tab_completion.pl's infrastructure for
invoking an interactive psql session out into a generally-useful test
function, but it didn't move enough stuff. We need to set up various
environment variables that readline will look at, both to ensure
stability of test results and to prevent test actions from cluttering
the calling user's ~/.psql_history. Expecting calling scripts to
remember to do that is too failure-prone: the other existing caller
001_password.pl did not do it. Hence, remove those initialization
steps from 010_tab_completion.pl and put them into interactive_psql().
Since interactive_psql was already making a local ENV hash, this has
no effect on calling scripts.

Discussion: https://postgr.es/m/794610.1703182896@sss.pgh.pa.us

Branch
------
REL_16_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/11652f919d44f865aa21e85c99fcd070bb36d883

Modified Files
--------------
src/bin/psql/t/010_tab_completion.pl | 26 ++++++--------------------
src/test/perl/PostgreSQL/Test/Cluster.pm | 28 ++++++++++++++++++++++++++--
2 files changed, 32 insertions(+), 22 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2023-12-24 02:30:21 Re: pgsql: Prevent tuples to be marked as dead in subtransactions on standb
Previous Message Tom Lane 2023-12-23 16:50:46 pgsql: Set readline-relevant ENV vars in interactive_psql(), not caller