From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Refactor pgstat_prepare_io_time() with an input argument instead |
Date: | 2023-12-16 19:18:23 |
Message-ID: | E1rEaB4-00AVvD-Hg@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Refactor pgstat_prepare_io_time() with an input argument instead of a GUC
Originally, this routine relied on track_io_timing to check if a time
interval for an I/O operation stored in pg_stat_io should be initialized
or not. However, the addition of WAL statistics to pg_stat_io requires
that the initialization happens when track_wal_io_timing is enabled,
which is dependent on the code path where the I/O operation happens.
Author: Nazir Bilal Yavuz
Discussion: https://postgr.es/m/CAN55FZ3AiQ+ZMxUuXnBpd0Rrh1YhwJ5FudkHg=JU0P+-W8T4Vg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/3c9d9acae0bc0cd2f905043cb1d581baec4622c4
Modified Files
--------------
src/backend/storage/buffer/bufmgr.c | 10 +++++-----
src/backend/storage/buffer/localbuf.c | 4 ++--
src/backend/storage/smgr/md.c | 4 ++--
src/backend/utils/activity/pgstat_io.c | 14 ++++++++++++--
src/include/pgstat.h | 2 +-
5 files changed, 22 insertions(+), 12 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2023-12-17 21:50:04 | pgsql: Doc: add a bit to indices.sgml about what is an indexable clause |
Previous Message | Alvaro Herrera | 2023-12-16 17:23:07 | pgsql: Remove useless LIMIT_OPTION_DEFAULT value from LimitOption |