pgsql: Fix nbtree backward scan race condition comments.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix nbtree backward scan race condition comments.
Date: 2023-12-08 23:38:09
Message-ID: E1rBkQ5-009GsF-3N@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix nbtree backward scan race condition comments.

Remove comments that supposed that holding a pin was a useful interlock
for _bt_walk_left(). There are times when _bt_walk_left() doesn't hold
either a lock or a pin on any page, so clearly this can't be true.
_bt_walk_left() is even prepared to deal with concurrent deletion of
both the original page and any pages to its left.

Oversight in commit 2ed5b87f96.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/aa210e0c121eb8f58c86d4fcc833a5a6fbb6f5a9

Modified Files
--------------
src/backend/access/nbtree/nbtsearch.c | 27 ++++++++-------------------
1 file changed, 8 insertions(+), 19 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2023-12-10 06:50:32 pgsql: Remove some unnecessary includes of "access/xlog_internal.h"
Previous Message Nathan Bossart 2023-12-08 19:41:40 pgsql: Micro-optimize JSONTYPE_NUMERIC code path in json.c.