pgsql: Adjust obsolete comment explaining set_stack_base().

From: Thomas Munro <tmunro(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Adjust obsolete comment explaining set_stack_base().
Date: 2023-12-01 02:20:36
Message-ID: E1r8t8t-0082g7-ML@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Adjust obsolete comment explaining set_stack_base().

Commit 7389aad6 removed the notion of backends started from inside a
signal handler. A stray comment still referred to them, while
explaining the need for a call to set_stack_base(). That leads to the
question of whether we still need the call in !EXEC_BACKEND builds.
There doesn't seem to be much point in suppressing it now, as it doesn't
hurt and probably helps to measure the stack base from the exact same
place in EXEC_BACKEND and !EXEC_BACKEND builds.

Back-patch to 16.

Reported-by: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Reported-by: Tristan Partin <tristan(at)neon(dot)tech>
Reported-by: Andres Freund <andres(at)anarazel(dot)de>
Discussion: https://postgr.es/m/CA%2BhUKG%2BEJHcevNGNOxVWxTNFbuB%3Dvjf4U68%2B85rAC_Sxvy2zEQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3b51265ee30784880fb2652051a4066ab9f9f90e

Modified Files
--------------
src/backend/utils/init/miscinit.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2023-12-01 02:20:46 pgsql: Adjust obsolete comment explaining set_stack_base().
Previous Message Heikki Linnakangas 2023-11-30 23:02:34 pgsql: Print lwlock stats also for aux processes, when built with LWLOC