pgsql: Clean up usage of bison precedence for non-operator keywords.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Clean up usage of bison precedence for non-operator keywords.
Date: 2023-11-28 18:32:20
Message-ID: E1r82se-007hLv-1S@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clean up usage of bison precedence for non-operator keywords.

Assigning a precedence to a keyword that isn't a kind of expression
operator is rather dangerous, because it might mask grammar
ambiguities that we'd rather know about. It's much safer to attach
explicit precedences to individual rules, which will affect the
behavior of only that one rule. Moreover, when we do have to give
a precedence to a non-operator keyword, we should try to give it the
same precedence as IDENT, thereby reducing the risk of surprising
side-effects.

Apply this hard-won knowledge to SET (which I misassigned ages ago
in commit 2647ad658) and some SQL/JSON-related productions
(from commits 6ee30209a, 71bfd1543).

Patch HEAD only, since there's no evidence of actual bugs here.

Discussion: https://postgr.es/m/CADT4RqBPdbsZW7HS1jJP319TMRHs1hzUiP=iRJYR6UqgHCrgNQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a916b47e23290ca24ffd083e5128d994f62966f6

Modified Files
--------------
src/backend/parser/gram.y | 61 ++++++++++++++++++++++++++++++++++-------------
1 file changed, 44 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2023-11-29 00:09:26 pgsql: Index SLRUs by 64-bit integers rather than by 32-bit integers
Previous Message Tom Lane 2023-11-28 17:34:18 pgsql: Use BIO_{get,set}_app_data instead of BIO_{get,set}_data.