pgsql: Check if ii_AmCache is NULL in aminsertcleanup

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Check if ii_AmCache is NULL in aminsertcleanup
Date: 2023-11-27 15:53:24
Message-ID: E1r7dvH-007WOn-OX@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Check if ii_AmCache is NULL in aminsertcleanup

Fix a bug introduced by c1ec02be1d79. It may happen that the executor
opens indexes on the result relation, but no rows end up being inserted.
Then the index_insert_cleanup still gets executed, but passes down NULL
to the AM callback. The AM callback may not expect this, as is the case
of brininsertcleanup, leading to a crash.

Fixed by only calling the cleanup callback if (ii_AmCache != NULL). This
way the AM can simply assume to only see a valid cache.

Reported-by: Richard Guo
Discussion: https://postgr.es/m/CAMbWs4-w9qC-o9hQox9UHvdVZAYTp8OrPQOKtwbvzWaRejTT=Q@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a82ee7ef3aacc2073d3ef5f4b7e5067fa08ea76c

Modified Files
--------------
src/backend/access/index/indexam.c | 2 +-
src/test/regress/expected/brin.out | 6 ++++++
src/test/regress/sql/brin.sql | 7 +++++++
3 files changed, 14 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2023-11-27 18:18:54 pgsql: Fix CREATE INDEX CONCURRENTLY example
Previous Message Heikki Linnakangas 2023-11-27 15:52:29 pgsql: Reduce rate of walwriter wakeups due to async commits.