| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Be more paranoid about OOM in search_path cache. |
| Date: | 2023-11-20 23:38:09 |
| Message-ID: | E1r5DqC-006Qoc-QD@gemulon.postgresql.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Be more paranoid about OOM in search_path cache.
Recent commit f26c2368dc introduced a search_path cache, but left some
potential out-of-memory hazards. Simplify the code and make it safer
against OOM.
This change reintroduces one list_copy(), losing a small amount of the
performance gained in f26c2368dc. A future change may optimize away
the list_copy() again if it can be done in a safer way.
Discussion: https://postgr.es/m/e6fded24cb8a2c53d4ef069d9f69cc7baaafe9ef.camel@j-davis.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8efa301532c8c93938e04451a74754c91b0b760d
Modified Files
--------------
src/backend/catalog/namespace.c | 119 ++++++++++++----------------------------
1 file changed, 36 insertions(+), 83 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2023-11-21 00:13:54 | pgsql: Optimize check_search_path() by using SearchPathCache. |
| Previous Message | Daniel Gustafsson | 2023-11-20 21:53:20 | Re: pgsql: llvmjit: Use explicit LLVMContextRef for inlining |