pgsql: Change logtape/tuplestore code to use int64 for block numbers

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Change logtape/tuplestore code to use int64 for block numbers
Date: 2023-11-17 02:23:38
Message-ID: E1r3oWA-005oas-0B@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Change logtape/tuplestore code to use int64 for block numbers

The code previously relied on "long" as type to track block numbers,
which would be 4 bytes in all Windows builds or any 32-bit builds. This
limited the code to be able to handle up to 16TB of data with the
default block size of 8kB, like during a CLUSTER. This code now relies
on a more portable int64, which should be more than enough for at least
the next 20 years to come.

This issue has been reported back in 2017, but nothing was done about it
back then, so here we go now.

Reported-by: Peter Geoghegan
Reviewed-by: Heikki Linnakangas
Discussion: https://postgr.es/m/CAH2-WznCscXnWmnj=STC0aSa7QG+BRedDnZsP=Jo_R9GUZvUrg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/b1e5c9fa9ac4399895bf312398c5d441baba0c3b

Modified Files
--------------
src/backend/storage/file/buffile.c | 10 +--
src/backend/utils/sort/logtape.c | 126 ++++++++++++++++++-------------------
src/backend/utils/sort/tuplesort.c | 12 ++--
src/include/storage/buffile.h | 4 +-
src/include/utils/logtape.h | 8 +--
5 files changed, 80 insertions(+), 80 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Daniel Gustafsson 2023-11-17 10:19:35 pgsql: llvmjit: Use explicit LLVMContextRef for inlining
Previous Message Michael Paquier 2023-11-17 01:56:30 pgsql: Remove NOT_USED BufFileTellBlock() from buffile.c