From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Extend sendFileWithContent() to handle custom content length in |
Date: | 2023-11-12 23:36:58 |
Message-ID: | E1r2K0f-0059NV-I8@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Extend sendFileWithContent() to handle custom content length in basebackup.c
sendFileWithContent() previously got the content length by using
strlen(), assuming that the content given is always a string. Some
patches are under discussion to pass binary contents to a base backup
stream, where an arbitrary length needs to be given by the caller
instead.
The patch extends sendFileWithContent() to be able to handle this case,
where len < 0 can be used to indicate an arbitrary length rather than
rely on strlen() for the content length.
A comment in sendFileWithContent() mentioned the backup_label file.
However, this routine is used by more file types, like the tablespace
map, so adjust it in passing.
Author: David Steele
Discussion: https://postgr.es/m/2daf8adc-8db7-4204-a7f2-a7e94e2bfa4b@pgmasters.net
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7606175991f8ed5ae36eecf6951cb89dcfb2156e
Modified Files
--------------
src/backend/backup/basebackup.c | 25 ++++++++++++++-----------
1 file changed, 14 insertions(+), 11 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Julien Rouhaud | 2023-11-13 00:53:45 | Re: pgsql: Extend sendFileWithContent() to handle custom content length in |
Previous Message | Michael Paquier | 2023-11-12 07:44:27 | pgsql: Add ability to reset all shared stats types in pg_stat_reset_sha |