pgsql: Fix AFTER ROW trigger execution in MERGE cross-partition update.

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix AFTER ROW trigger execution in MERGE cross-partition update.
Date: 2023-11-09 11:30:18
Message-ID: E1r13Eo-004eDZ-6Y@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix AFTER ROW trigger execution in MERGE cross-partition update.

When executing a MERGE UPDATE action, if the UPDATE is turned into a
cross-partition DELETE then INSERT, do not attempt to invoke AFTER
UPDATE ROW triggers, or any of the other post-update actions in
ExecUpdateEpilogue().

For consistency with a plain UPDATE command, such triggers should not
be fired (and typically fail anyway), and similarly, other post-update
actions, such as WCO/RLS checks should not be executed, and might also
lead to unexpected failures.

Therefore, as with ExecUpdate(), make ExecMergeMatched() return
immediately if ExecUpdateAct() reports that a cross-partition update
was done, to be sure that no further processing is done for that
tuple.

Back-patch to v15, where MERGE was introduced.

Discussion: https://postgr.es/m/CAEZATCWjBgagyNZs02vgDF0DvASYj-iHTFtXG2-nP3orZhmtcw%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a4f7d33a904fcd4da7a12d249416dd2c5c5f2c1c

Modified Files
--------------
src/backend/executor/nodeModifyTable.c | 16 ++++++++++++
src/test/regress/expected/triggers.out | 45 ++++++++++++++++++++++++++++++++++
src/test/regress/sql/triggers.sql | 36 +++++++++++++++++++++++++++
3 files changed, 97 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2023-11-09 12:11:32 pgsql: Avoid integer overflow hazard in interval_time().
Previous Message David Rowley 2023-11-09 11:18:50 pgsql: Ensure we use the correct spelling of "ensure"