From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix bug in the new ResourceOwner implementation. |
Date: | 2023-11-08 23:48:55 |
Message-ID: | E1r0sI2-004Z5s-U5@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix bug in the new ResourceOwner implementation.
When the hash table is in use, ResoureOwnerSort() moves any elements
from the small fixed-size array to the hash table, and sorts it. When
the hash table is not in use, it sorts the elements in the small
fixed-size array directly. However, ResourceOwnerSort() and
ResourceOwnerReleaseAll() had different idea on when the hash table is
in use: ResourceOwnerSort() checked owner->nhash != 0, and
ResourceOwnerReleaseAll() checked owner->hash != NULL. If the hash
table was allocated but was currently empty, you hit an assertion
failure.
Reported-by: Alexander Lakhin <exclusion(at)gmail(dot)com>
Discussion: https://www.postgresql.org/message-id/be58d565-9e95-d417-4e47-f6bd408dea4b@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8f4a1ab471e6a258881e3d7f5883705714cde7e1
Modified Files
--------------
src/backend/utils/resowner/resowner.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2023-11-09 01:08:21 | pgsql: pg_stat_statements: Remove duplicated tests for SET statements |
Previous Message | Bruce Momjian | 2023-11-08 21:49:05 | pgsql: doc:: simplify introductory text |