pgsql: Be more wary about NULL values for GUC string variables.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Be more wary about NULL values for GUC string variables.
Date: 2023-11-02 15:53:42
Message-ID: E1qya0r-003brB-SL@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Be more wary about NULL values for GUC string variables.

get_explain_guc_options() crashed if a string GUC marked GUC_EXPLAIN
has a NULL boot_val. Nosing around found a couple of other places
that seemed insufficiently cautious about NULL string values, although
those are likely unreachable in practice. Add some commentary
defining the expectations for NULL values of string variables,
in hopes of forestalling future additions of more such bugs.

Xing Guo, Aleksander Alekseev, Tom Lane

Discussion: https://postgr.es/m/CACpMh+AyDx5YUpPaAgzVwC1d8zfOL4JoD-uyFDnNSa1z0EsDQQ@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7704a1a72e879daaefa1742916e01505edd2ce47

Modified Files
--------------
src/backend/utils/misc/guc.c | 16 +++++++++++++---
src/include/utils/guc_tables.h | 10 ++++++++++
2 files changed, 23 insertions(+), 3 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2023-11-02 23:35:56 pgsql: Stabilize postgres_fdw tests on 32-bit machines
Previous Message David Rowley 2023-11-02 10:18:03 pgsql: Attempt to stabilize postgres_fdw tests