pgsql: btree_gin: Fix calculation of leftmost interval value.

From: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: btree_gin: Fix calculation of leftmost interval value.
Date: 2023-10-29 11:23:35
Message-ID: E1qx3tH-002wWV-2Z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

btree_gin: Fix calculation of leftmost interval value.

Formerly, the value computed by leftmostvalue_interval() was a long
way short of the minimum possible interval value. As a result, an
index scan on a GIN index on an interval column with < or <= operators
would miss large negative interval values.

Fix by setting all fields of the leftmost interval to their minimum
values, ensuring that the result is less than any other possible
interval. Since this only affects index searches, no index rebuild is
necessary.

Back-patch to all supported branches.

Dean Rasheed, reviewed by Heikki Linnakangas.

Discussion: https://postgr.es/m/CAEZATCV80%2BgOfF8ehNUUfaKBZgZMDfCfL-g1HhWGb6kC3rpDfw%40mail.gmail.com

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c804ffb5622b5efe7bda78570aa1911073a7491d

Modified Files
--------------
contrib/btree_gin/btree_gin.c | 6 +++---
contrib/btree_gin/expected/interval.out | 16 +++++++++++-----
contrib/btree_gin/sql/interval.sql | 4 +++-
3 files changed, 17 insertions(+), 9 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Dean Rasheed 2023-10-29 15:54:14 pgsql: Guard against overflow in make_interval().
Previous Message Hayato Kuroda (Fujitsu) 2023-10-29 05:43:46 RE: pg_upgrade test failure